Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top-level plots section #14

Closed
daavoo opened this issue Jun 27, 2022 · 3 comments · Fixed by #19
Closed

Add top-level plots section #14

daavoo opened this issue Jun 27, 2022 · 3 comments · Fixed by #19
Assignees
@pared

Comments

@daavoo
Copy link
Contributor

daavoo commented Jun 27, 2022

Per iterative/dvc#7477
@daavoo daavoo changed the title Add tio-level plots section Add top-level plots section Jun 27, 2022
@dberenbaum
Copy link
Contributor

This may be important for iterative/vscode-dvc#1192.

@skshetry
Copy link
Member

We should keep the implementation and this schema always in sync.

What's the format of plots? In the schema, I only see dict (cc @pared, the schema should be stricter): https://github.com/iterative/dvc/blob/512bfc4305a7607f63514dc734663c973ed954b2/dvc/schema.py#L59.

Let me know if you need help here. :)

@pared
Copy link

pared commented Aug 26, 2022

Sorry, @skshetry I didn't add it to my TODO's, I don't expect that help will be needed, adding it rn.

@pared pared self-assigned this Aug 26, 2022
@daavoo daavoo linked a pull request Sep 14, 2022 that will close this issue
add schema for top-level plots #19
Merged
@skshetry skshetry mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
None yet
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
4 participants
@dberenbaum @pared @daavoo @skshetry