-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next_step() needs log() #232
Comments
The Not sure what to do here. The summary is intended to track logged scalars and we just include cc @dberenbaum |
Seems odd to do this. If there are multiple things to log per iteration, you dump multiple times?
I don't quite follow the wording in #145 but from what I can tell it seems identical to this issue (#232) so shouldn't have been closed? |
@casperdcl Why do you want to use Edit: To clarify, I meant that your expectations seem reasonable, but I'd like to better understand the context. |
Full context is Second unrelated lower-priority follow-up issue is optimisation:
|
We probably need to decouple @casperdcl I moved the optimization to #238. Both are good points that are largely due to changes in the codebase over time and should probably be changed now AFAIK. |
Actually, I think we just need to call |
current:dvclive.json
is stuck onstep: 0
if we remove thelive.log()
command.make_{x}
tonext_step()
. #353)dvclive.json
doesn't exists if we remove thelive.log()
command.step: 9
even withoutlive.log()
Related: iterative/cml.dev#207
The text was updated successfully, but these errors were encountered: