Skip to content

expose connect_timeout on HTTP remote #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
palenge opened this issue Sep 26, 2022 · 2 comments · Fixed by #25
Closed

expose connect_timeout on HTTP remote #15

palenge opened this issue Sep 26, 2022 · 2 comments · Fixed by #25

Comments

@palenge
Copy link

palenge commented Sep 26, 2022

Hi!
We have a HTTP remote, when we upload dig files we get connection timeout. There is any way to expose this property already exposed on S3?

@efiop efiop transferred this issue from iterative/dvc Sep 26, 2022
@cklukas
Copy link

cklukas commented Dec 6, 2022

Please undo this change:
c1cdbb3#diff-81659e042f9d6ace20f56bc9182f71b64f14dcabb7f4a0dce2baa505d52383a6R121

This timeout means, that uploads need to finish in 60 seconds, causing major problems when using http remote to upload larger files. The timeout in our environment causes the upload to stop after 60 seconds, as until the upload is finished no response is send back to the client, causing a read-timeout. Please remove this timeout (set value to None), or make it possible, to set this through a setting on the dvc remote config, and/or through a environment variable.

@dtrifiro
Copy link
Contributor

@cklukas Hi. That's not exactly how it works. sock_read sets the timeout for receiving data on the socket, meaning that if no data is received for 60s, the socket is forcefully closed (e.g. see aiohttp docs here: https://docs.aiohttp.org/en/stable/client_quickstart.html#timeouts).

I do agree that there's some issue with timeouts and we'll be working to expose timeout options to avoid this kind of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants