Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop .edatachain support #853

Merged
merged 1 commit into from
Jan 24, 2025
Merged

drop .edatachain support #853

merged 1 commit into from
Jan 24, 2025

Conversation

skshetry
Copy link
Member

Closes #749

@skshetry skshetry requested a review from a team January 23, 2025 07:17
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.52%. Comparing base (740be82) to head (f167bb4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/catalog/catalog.py 57.14% 0 Missing and 3 partials ⚠️
src/datachain/listing.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   87.42%   87.52%   +0.09%     
==========================================
  Files         128      128              
  Lines       11429    11358      -71     
  Branches     1559     1538      -21     
==========================================
- Hits         9992     9941      -51     
+ Misses       1042     1030      -12     
+ Partials      395      387       -8
Flag Coverage Δ
datachain 87.46% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit 74ea452 into main Jan 24, 2025
32 of 37 checks passed
@skshetry skshetry deleted the fix-749 branch January 24, 2025 03:11
dreadatour pushed a commit that referenced this pull request Jan 27, 2025
@skshetry @dreadatour
drop .edatachain support (#853)
55cd044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop edatachain file support and logic around it
3 participants
@skshetry @shcheklein @0x2b3bfa0