Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QueryGenerator #456

Open
rlamy opened this issue Sep 18, 2024 · 0 comments
Open

Remove QueryGenerator #456

rlamy opened this issue Sep 18, 2024 · 0 comments
Assignees
@amritghimire
Labels
housekeeping priority-p2

Comments

@rlamy
Copy link
Contributor

rlamy commented Sep 18, 2024

QueryGenerator is effectively a wrapper around a SQLAlchemy query and everything we do with it could be done with a sa.Selectable. Removing it would simplify the code and make the code flow easier to follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amritghimire amritghimire

Labels
housekeeping priority-p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlamy @shcheklein @amritghimire