fix GHA workflow timeout-minutes 4320 #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

2 tasks

casperdcl opened this issue Jul 19, 2022 · 1 comment

Assignees

Labels

bug ci-github cml-runner

Contributor

casperdcl commented Jul 19, 2022 •

edited

Loading

there are quite a few workflows with hardcoded timeout-minutes: 4320. Said workflows are broken due to #1067.

Also users who notice the warning and upgrade to timeout-minutes: 50400 will still see an annoyingly persistent warning.

As per #1067 (comment) we should:

increase visibility or automate a fix
- minimum (easy): throw an error instead of logging a warning
- ideally (more involved): parse the workflow file and set GH_5_MIN_TIMEOUT accordingly
better logging
- https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message and/or https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary, etc.

The text was updated successfully, but these errors were encountered:

casperdcl added bug cml-runner ci-github labels

casperdcl mentioned this issue

fix: Increase GHA workflow timeout to 35 days from 72h #1067

Merged

casperdcl assigned dacbd

Contributor Author

casperdcl commented Nov 29, 2022

potentially need to repurpose for general restart mechanism issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment