Skip to content

Commit 7ba6e59

Browse files
committed
slight docs & var name tweaks
1 parent 241f230 commit 7ba6e59

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ environment variables for passing your cloud service credentials to the
411411
workflow.
412412

413413
Note that `cml runner` will also automatically restart your jobs (whether from a
414-
[GitHub Actions 35 day workflow timeout](https://docs.github.com/en/actions/reference/usage-limits-billing-and-administration#usage-limits)
414+
[GitHub Actions 35-day workflow timeout](https://docs.github.com/en/actions/reference/usage-limits-billing-and-administration#usage-limits)
415415
or a
416416
[AWS EC2 spot instance interruption](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-interruptions.html)).
417417

@@ -438,7 +438,7 @@ jobs:
438438
train-model:
439439
needs: deploy-runner
440440
runs-on: [self-hosted, cml-gpu]
441-
timeout-minutes: 4320 # 72h - up to 50400 (35d) supported
441+
timeout-minutes: 50400 # 35 days
442442
container:
443443
image: docker://iterativeai/cml:0-dvc2-base1-gpu
444444
options: --gpus all

bin/cml/runner.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ let RUNNER_ID;
1515
let RUNNER_JOBS_RUNNING = [];
1616
let RUNNER_SHUTTING_DOWN = false;
1717
let RUNNER_TIMER = 0;
18-
const GHA_WORKFLOW_TIMEOUT = (35 * 24 * 60 - 5) * 60 * 1000;
18+
const GH_5_MIN_TIMEOUT = (35 * 24 * 60 - 5) * 60 * 1000;
1919

2020
const shutdown = async (opts) => {
2121
if (RUNNER_SHUTTING_DOWN) return;
@@ -321,9 +321,9 @@ const runLocal = async (opts) => {
321321
RUNNER_JOBS_RUNNING.forEach((job) => {
322322
if (
323323
new Date().getTime() - new Date(job.date).getTime() >
324-
GHA_WORKFLOW_TIMEOUT
324+
GH_5_MIN_TIMEOUT
325325
) {
326-
shutdown({ ...opts, reason: 'timeout:35d' });
326+
shutdown({ ...opts, reason: 'timeout:35days' });
327327
clearInterval(watcherSeventyTwo);
328328
}
329329
});

0 commit comments

Comments
 (0)