Provider login/consent views do not read client_name correctly #297
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
The provider authz_request_view shows the client_organization_name to the user in the login page. It reads the name from the resolved metadata, and falls back to client_id.
spid-cie-oidc-django/spid_cie_oidc/provider/views/authz_request_view.py
Lines 202 to 204 in b7b28a8
Same goes for consent
spid-cie-oidc-django/spid_cie_oidc/provider/views/consent_page_view.py
Lines 59 to 61 in b7b28a8
The client_name is always blank, because it is provided inside the
openid_relying_party
subsection.something like this fixes the issue
I'm also wondering whether displaying the client_name is the best approach here, given that we should have the proper organization_name inside the federation metadata, which is required for CIE/SPID RPs as per https://docs.italia.it/italia/spid/spid-cie-oidc-docs/it/versione-corrente/metadata_oidc_rp.html
The text was updated successfully, but these errors were encountered: