Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review our media-player (and overlay) #1506

Closed
1 task done
Fupete opened this issue Jan 17, 2025 · 2 comments · Fixed by #1529
Closed
1 task done

Review our media-player (and overlay) #1506

Fupete opened this issue Jan 17, 2025 · 2 comments · Fixed by #1529
Labels
enhancement

Comments

@Fupete
Copy link
Collaborator

Fupete commented Jan 17, 2025 •
edited
Loading

Does a discussion already exist on the topic you are interested in, or on a similar topic?

  • I verified and it doesn't exist

What

There are a bunch of console errors in our current implementation (CORS, rerenders, ...).

Why

Best practices. Resources.

Context

No response

More

Also linked to this: #1505

This debugging PR could be usefull for testing: #1507
@Fupete Fupete moved this to ✏ Todo in Designers Italia - Website Jan 17, 2025
@Fupete
Copy link
Collaborator Author

Fupete commented Jan 17, 2025

cc @astagi

@Fupete
Copy link
Collaborator Author

Fupete commented Jan 17, 2025

Some console (localhost) screens:

Image

@astagi astagi mentioned this issue Feb 6, 2025
Merged
@Fupete Fupete moved this from ✏ Todo to 🛠 Doing in Designers Italia - Website Feb 7, 2025
@github-project-automation github-project-automation bot moved this from 🛠 Doing to ✅ Done in Designers Italia - Website Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Designers Italia - Website
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use lodable to avoid media player ssr italia/designers.italia.it
1 participant
@Fupete