Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 #230

Open
deed02392 opened this issue Nov 11, 2019 · 6 comments
Open

Python 3 #230

deed02392 opened this issue Nov 11, 2019 · 6 comments

Comments

@deed02392
Copy link

deed02392 commented Nov 11, 2019

Issue to register the request to migrate fully to Python 3.

@deed02392 deed02392 changed the title Python 3 support Python 3 Nov 11, 2019
@madisonb
Copy link
Collaborator

@deed02392 Does the python 3 containers not work for you right now? The master branch is not up to date, but the project on the dev branch is fully python 3 compatible. I agree we should migrate all the way over but that might just mean that we drop support for python 2 setups/containers/installs.

@deed02392
Copy link
Author

deed02392 commented Nov 19, 2019

Hey @madisonb, well, they were not working well with the latest Alpine Linux based Python 3 container. I basically had to update a lot of packages to get things working on the Scrapy container. I only got as far as making that run again after updating all the dependencies, but I think I will need to do the same for the other Docker components.

@cyclehacker
Copy link

Hi @madisonb what is the current status with running the master branch with python 3? I also noticed the requirements.txt file is depreciated, what specifically should I alter/add to ensure all requirements are met? Thanks.

@madisonb
Copy link
Collaborator

All of the unit and integration tests for the python3 docker container continue to pass, here is the build from lasst week.

https://travis-ci.org/github/istresearch/scrapy-cluster/jobs/664497952

I'm not sure there is much more to be done for the base version of this project if you are using the dev branch.

@psdon
Copy link

psdon commented Dec 4, 2020

I tried to run this on Python3.8 but it doesn't work. lots of dependencies need to work on

@madisonb
Copy link
Collaborator

I will gladly accept a PR to upgrade the project to something beyond python 3.6. I have not done any testing beyond what runs in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants