Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation - possibility to circunvent quota check by adding the grade by hand #26

Open
joantune opened this issue Apr 17, 2013 · 2 comments
Open

Validation - possibility to circunvent quota check by adding the grade by hand #26

joantune opened this issue Apr 17, 2013 · 2 comments
Labels
bug

Comments

@joantune
Copy link
Contributor

No description provided.

@joantune joantune mentioned this issue Apr 18, 2013
Open
@joantune
Copy link
Contributor Author

Will only solve when doing the #29

@joantune
Copy link
Contributor Author

The problem lays with the hasPositiveValidationAssessment(personSiadapWrapper) of the following part of the SiadapGradePredicate:
&& (!considerValidatedOnly || (siadap.hasCompleteValidationAssessment(siadapUniverseToConsider) && hasPositiveValidationAssessment(personSiadapWrapper)

Now, one should break up this predicate into several, like stated in #29, or have to make sure that his part is only needed in the Validation case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joantune