Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missions] Mission.isApproved() is ambiguous and should be removed #47

Open
JoaoRoxoNeves opened this issue Jun 17, 2013 · 0 comments
Open

Comments

@JoaoRoxoNeves
Copy link
Contributor

As an API method, the logic that this method implements is not clear.
In the context of a MissionProcess, the "approval" keyword is used to represent the first step of approval by the mission's responsible.
That logic is already implemented in isApprovedByMissionResponsible()

The method isApproved() should be removed, and any references to it should be refactored.

@Luis-Cruz Luis-Cruz modified the milestone: Release v3.0.0 Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants