From 1da2f5d6436e906a263e96e782081b092512fd46 Mon Sep 17 00:00:00 2001 From: Sameer Sheorey Date: Fri, 3 Jan 2025 13:26:25 -0800 Subject: [PATCH] Misc updates --- cpp/apps/CMakeLists.txt | 3 +-- cpp/apps/Open3DViewer/Info.plist.in | 14 +++++++------- cpp/apps/Open3DViewer/Open3DViewer.xml | 2 +- .../visualization/visualizer/GuiVisualizer.cpp | 5 +---- 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/cpp/apps/CMakeLists.txt b/cpp/apps/CMakeLists.txt index 1d12f58cc24..a0efa960d3c 100644 --- a/cpp/apps/CMakeLists.txt +++ b/cpp/apps/CMakeLists.txt @@ -14,11 +14,10 @@ macro(open3d_add_app_gui SRC_DIR APP_NAME TARGET_NAME) set(MACOSX_BUNDLE_NAME ${APP_NAME}) set(MACOSX_BUNDLE_EXECUTABLE_NAME ${APP_NAME}) set(MACOSX_BUNDLE_GUI_IDENTIFIER com.isl-org.open3d.${APP_NAME}) - set(MACOSX_BUNDLE_ICON_FILE "AppIcon") set(MACOSX_BUNDLE_LONG_VERSION_STRING ${PROJECT_VERSION_THREE_NUMBER}) set(MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_THREE_NUMBER}) set(MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION_THREE_NUMBER}) - set(MACOSX_BUNDLE_COPYRIGHT "Copyright (c) 2018-2023 www.open3d.org") + set(MACOSX_BUNDLE_COPYRIGHT "Copyright (c) 2018-2025 www.open3d.org") endif() # Copy the resource files. This needs to be done as a post-build step diff --git a/cpp/apps/Open3DViewer/Info.plist.in b/cpp/apps/Open3DViewer/Info.plist.in index e705ada2292..2e90b4bc779 100644 --- a/cpp/apps/Open3DViewer/Info.plist.in +++ b/cpp/apps/Open3DViewer/Info.plist.in @@ -11,9 +11,9 @@ CFBundleGetInfoString ${MACOSX_BUNDLE_INFO_STRING} CFBundleIconFile - ${MACOSX_BUNDLE_ICON_FILE} + AppIcon CFBundleIconName - ${MACOSX_BUNDLE_ICON_FILE} + AppIcon CFBundleIdentifier ${MACOSX_BUNDLE_GUI_IDENTIFIER} CFBundleInfoDictionaryVersion @@ -77,11 +77,11 @@ LSHandlerRank Owner - + CFBundleTypeIconFile documentIcon CFBundleTypeName - GL Binary Transmission Format + GL Transmission Format (Binary) CFBundleTypeRole Editor LSIsAppleDefaultForType @@ -318,7 +318,7 @@ public.mime-type - model/gltf + model/gltf+json @@ -332,7 +332,7 @@ public.data UTTypeDescription - GL Binary Transmission Format + GL Transmission Format (Binary) UTTypeTagSpecification public.filename-extension @@ -341,7 +341,7 @@ public.mime-type - model/glb + model/glb-binary diff --git a/cpp/apps/Open3DViewer/Open3DViewer.xml b/cpp/apps/Open3DViewer/Open3DViewer.xml index 697129388d9..8300b67da16 100644 --- a/cpp/apps/Open3DViewer/Open3DViewer.xml +++ b/cpp/apps/Open3DViewer/Open3DViewer.xml @@ -49,7 +49,7 @@ - GL Transmission Format + GL Transmission Format (Binary) diff --git a/cpp/open3d/visualization/visualizer/GuiVisualizer.cpp b/cpp/open3d/visualization/visualizer/GuiVisualizer.cpp index 62b6b3fca99..5f7584d7e00 100644 --- a/cpp/open3d/visualization/visualizer/GuiVisualizer.cpp +++ b/cpp/open3d/visualization/visualizer/GuiVisualizer.cpp @@ -1166,10 +1166,7 @@ void GuiVisualizer::LoadGeometry(const std::string &path) { model_success = false; } } - if (!model_success) { - utility::LogInfo("{} appears to be a point cloud", path.c_str()); - } - + // path appears to be a point cloud... auto geometry = std::shared_ptr(); if (!model_success) { auto cloud = std::make_shared();