Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify non-subset learners to take advantage of better continuous feature matching #1121

Open
spigo900 opened this issue Apr 19, 2022 · 0 comments

Comments

@spigo900
Copy link
Collaborator

We have several learners, but in our current plan only subset can currently make use of our improved continuous feature matching. Extending this to other learners is out of scope for the foreseeable future. However, it seems worth documenting this as "not implemented" since the lack of an implementation would otherwise be hard to notice without running experiments.

I think there are two related things we would need to handle for this issue if we needed to address it:

  1. Figure out and implement a way of doing updates. This means figuring out when/how to call confirm_match() on some pattern match info, or how we would update continuous nodes if we didn't do it by confirming matches the way we do now. There may be obvious times and places to do this for some learners; for others it may be less obvious.
  2. Handle the new continuous predicate node type properly for pattern-pattern matching and for the pattern generalization some non-subset learners do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant