Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated LRE script run #72

Closed
jp7745 opened this issue Dec 11, 2024 · 5 comments
Closed

updated LRE script run #72

jp7745 opened this issue Dec 11, 2024 · 5 comments

Comments

@jp7745
Copy link
Member

jp7745 commented Dec 11, 2024

I want to take stock of the necessary inputs and updates we need to take care of before we run the scripts/compute_all_LREs_script.py again.

  1. @jtcantin: are you sending any more MPSs to alex to compute overlaps?
  2. @aakunitsa: overlaps.csv up-to-date? are any more overlaps being computed? are the latest living in the overlaps branch?
  3. @aakunitsa: is the script/code to go from MPS to overlap living in some repo?
  4. @max-radin : any updates to the LRE script? we will run it again with the overlaps and ONLY produce LRE for Hamiltonians we have overlaps for.
  5. @max-radin: any more concerns with the df_threshold or other settings relevant to PyLIQTR? any updates?

what other items are prerequisites or blockers?

@jtcantin
Copy link
Contributor

jtcantin commented Dec 11, 2024 via email

@max-radin
Copy link
Contributor

The only update I am working on to the LRE script is to add the sf_threshold to the config file. I'll open a PR with this update later today.

Regarding the concerns in #24, I did some experiments to investigate effect of sf_threshold and confirmed that increasing the sf_threshold to 1e-8 doesn't affect the resource estimates very much. Which makes me less concerned about the warning message we get with sf_threshold set to 1e-12. I'll post some more details on that issue shortly.

@aakunitsa
Copy link
Contributor

aakunitsa commented Dec 12, 2024 via email

@max-radin
Copy link
Contributor

Here is the PR that adds sf_threshold to the config file: #76.

@jp7745
Copy link
Member Author

jp7745 commented Dec 16, 2024

completed and merged johnp/LRE-run.

@jp7745 jp7745 closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants