Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRE script reports incorrect confidence level #157

Closed
max-radin opened this issue Jan 23, 2025 · 1 comment · Fixed by #165
Closed

LRE script reports incorrect confidence level #157

max-radin opened this issue Jan 23, 2025 · 1 comment · Fixed by #165
Labels
bug Something isn't working medium priority

Comments

@max-radin
Copy link
Contributor

Right now, the LRE script reports the confidence level as 1 - probability_of_success (0.01). The confidence level should instead be reported as probability_of_success (0.99).

I don't think this bug has any downstream consequences at the moment because, as far as I know, the reported confidence level does not get used anywhere.
@max-radin max-radin added bug Something isn't working medium priority labels Jan 23, 2025
@jp7745
Copy link
Member

jp7745 commented Jan 23, 2025

The LRE script is running right now and yes, it is reporting the incorrect confidence. No, it does not get used anywhere else. So this can be fixed later in February. Please incorporate this fix into #86 (avoid recalculating LREs at the task_uuid level).

@max-radin max-radin mentioned this issue Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing failure tolerance reporting isi-usc-edu/qb-gsee-benchmark
2 participants
@max-radin @jp7745