Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-norm does not account for double factorization truncation threshold #31

Open
max-radin opened this issue Dec 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@max-radin
Copy link

Right now, resource estimates for DF QPE might be somewhat overestimated because the one-norm calculation in pyLIQTR.ProblemInstances.ChemicalHamiltonian.get_alpha does not account for the double-factorization threshold df_error_threshold. (Note: I've already discussed this with @kjm538, just posting an issue here so that it's easier to keep track.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant