Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np.float #10

Open
andrewendlinger opened this issue Dec 30, 2022 · 3 comments
Open

np.float #10

andrewendlinger opened this issue Dec 30, 2022 · 3 comments

Comments

@andrewendlinger
Copy link

In the latest numpy version (1.24.1) the use of 'np.float' raises an error. 'np.float' is e.g. used in brukerapi/schemas.py: line 580.

According to the DepricationWarning from an earlier numpy version, this is a quick fix:
DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

@wtclarke
Copy link
Contributor

Hi @tomas-psorn Just chipping in to say that I'm also seeing issues with this. e.g.

size = (np.int(size_str),)
.

I will open a PR for this and the above np.float (and any others that I can spot) shortly.

BW

Will

@wtclarke
Copy link
Contributor

PR now made. See #11

@musicinmybrain
Copy link

Since #11 was merged and released, it seems like this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants