gather function for gpuarray produces error in oiPad on system without parallel toolbox

[wandell]

Not sure what checking has to happen. But v_ISETBIO now fails for me.

We need a way to establish the presence of special toolboxes and to protect against these failures.

The error is arises from the introduction of the 'gather' function for gpu computing. The try/catch can get into a state when padval is not set. (Error message below).

---

Undefined function or variable "padval".

Error in oiPad (line 51)
[r,c] = size(padarray(photons(:,:,1),padSize,padval,direction));

Error in opticsOTF>oiApplyOTF (line 79)
oi = oiPad(oi, padSize, sDist);

Error in opticsOTF (line 46)
oi = oiApplyOTF(oi, scene, 'mm');

Error in opticsSICompute (line 64)
oi = opticsOTF(oi,scene);

Error in oiCompute (line 78)
oi = opticsSICompute(scene,oi);

Error in v_oi (line 19)
oi = oiCompute(oi,scene);

Error in v_ISETBIO (line 27)
v_oi

[hjiang36]

Thanks for pointing it out.
It's an error from the last commit that fixed the gather issue on early Matlab version. I prefer to add an else condition in padval computation. But anyway, we could also revert the last commit. Or, I'm totally fine to revert the merge for GPU computing. I guess there's no one else using GPU except for me.

Besides, knowing which testing scripts to be run before commit seems to be important. Let me know if there's already one.

Best,
HJ

[wandell]

I think it is great that you are moving the gpu computing along. Let's just protect against missing toolboxes. I think in this case setting the padval will fix things.

The pre commit test at the moment is v_ISETBIO. I think the Nicolas is planning on improving that stuff, which will be great.