Add volume readiness check and corresponding tests for CreateVolume
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujeet01
force-pushed
the
enh/create-volume-readiness
branch
from
a1690f4
to
066b06a
Compare
This commit introduces a new function, 'waitForVolumeAvailability', to the 'CreateVolume' function of our CSI driver. This function ensures that a volume reaches the 'Available' state before the 'CreateVolume' request is completed. To validate this functionality, corresponding tests have been added. This enhancement improves reliability and provides clearer error messages for debugging.
sujeet01
force-pushed
the
enh/create-volume-readiness
branch
from
066b06a
to
aa9be38
Compare
- Change the log message from "Volume applied and is now available" to "Applied volume" with additional information about the volume state. Signed-off-by: Andreas Fritzler <[email protected]>
afritzler
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateVolumeFixes Wait until aVolumebecomes ready before completingCreateVolume#312go mod tidyto makefile targettest