From 109da33b306b34f5655ffa238b8d64afd2c38e31 Mon Sep 17 00:00:00 2001 From: Damyan Yordanov Date: Wed, 20 Mar 2024 13:20:22 +0100 Subject: [PATCH] Do not update IP on deletion The finalizer has already been removed, so the object is not existing --- controllers/ip_controller.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/controllers/ip_controller.go b/controllers/ip_controller.go index 9d35d16..a9996a0 100644 --- a/controllers/ip_controller.go +++ b/controllers/ip_controller.go @@ -69,11 +69,6 @@ func (r *IPReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Re } controllerutil.RemoveFinalizer(ip, CIPFinalizer) - err := r.Update(ctx, ip) - if err != nil { - log.Error(err, "unable to update ip resource on finalizer removal", "name", req.NamespacedName) - return ctrl.Result{}, err - } } return ctrl.Result{}, nil }