From 69a64ce7197fd65cf29e2c23a0445e5489d8b9dd Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 18 Dec 2024 10:11:09 -0800 Subject: [PATCH 01/21] Update workflow to use conductor runner Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index a1b80731afb3..65a98da5ee77 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -19,7 +19,7 @@ on: jobs: test_mi300: - runs-on: nodai-amdgpu-mi300-x86-64 + runs-on: arc-iree-gpu-1 env: PACKAGE_DOWNLOAD_DIR: ${{ github.workspace }}/.packages BUILD_DIR: build-tests From c01e9ff8b2982567952a583678311662a5b04ff4 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 18 Dec 2024 10:24:48 -0800 Subject: [PATCH 02/21] Corrected to use label not namespace Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 65a98da5ee77..a6bacc91bab1 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -19,7 +19,7 @@ on: jobs: test_mi300: - runs-on: arc-iree-gpu-1 + runs-on: linux-mi300-gpu-1 env: PACKAGE_DOWNLOAD_DIR: ${{ github.workspace }}/.packages BUILD_DIR: build-tests From 4b8327ada6813297de918790c4484e0288033716 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 18 Dec 2024 15:13:46 -0800 Subject: [PATCH 03/21] Explicit set container image for dependencies Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index a6bacc91bab1..1f5e41298776 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -20,6 +20,8 @@ on: jobs: test_mi300: runs-on: linux-mi300-gpu-1 + container: + image: rocm/dev-ubuntu-22.04:6.3 env: PACKAGE_DOWNLOAD_DIR: ${{ github.workspace }}/.packages BUILD_DIR: build-tests From a3691249a3da0d59503c7c4403656be5e14951dd Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Fri, 3 Jan 2025 17:52:22 -0800 Subject: [PATCH 04/21] Add missing depedencies when switching docker image Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 1f5e41298776..52fd1656752b 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -53,6 +53,7 @@ jobs: ./build_tools/pkgci/setup_venv.py ${VENV_DIR} \ --artifact-path=${PACKAGE_DOWNLOAD_DIR} \ --fetch-gh-workflow=${{ inputs.artifact_run_id }} + sudo apt install -y cmake ninja-build clang lld git - name: Build tests run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin From 7aefe9892e571d77245bfdfbb6b92ce5ae200ff6 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Sun, 5 Jan 2025 21:17:23 -0800 Subject: [PATCH 05/21] Remove trailing white spaces Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 52fd1656752b..df922f30751a 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -53,7 +53,7 @@ jobs: ./build_tools/pkgci/setup_venv.py ${VENV_DIR} \ --artifact-path=${PACKAGE_DOWNLOAD_DIR} \ --fetch-gh-workflow=${{ inputs.artifact_run_id }} - sudo apt install -y cmake ninja-build clang lld git + sudo apt install -y cmake ninja-build clang lld git - name: Build tests run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin From b1240fe83a98644646f96e825509b4c1d55b1c43 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Mon, 6 Jan 2025 15:11:15 -0800 Subject: [PATCH 06/21] move sudo install up Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index df922f30751a..25828d29c02d 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,7 +39,9 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: ./build_tools/scripts/git/update_runtime_submodules.sh + run: | + sudo apt install -y cmake ninja-build clang lld git + ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. @@ -53,7 +55,7 @@ jobs: ./build_tools/pkgci/setup_venv.py ${VENV_DIR} \ --artifact-path=${PACKAGE_DOWNLOAD_DIR} \ --fetch-gh-workflow=${{ inputs.artifact_run_id }} - sudo apt install -y cmake ninja-build clang lld git + - name: Build tests run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin From 85e00722718ecd17893254cd96f6a211dec3944a Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Mon, 6 Jan 2025 16:27:49 -0800 Subject: [PATCH 07/21] try and error Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 25828d29c02d..1cd562669a1e 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,7 +39,7 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: | + run: sudo apt install -y cmake ninja-build clang lld git ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 2f92e437e540361671fbaa2e1cbd9651f1e7f40c Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Mon, 6 Jan 2025 16:43:35 -0800 Subject: [PATCH 08/21] Combine commands Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 1cd562669a1e..c0aa6bafa2fb 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,9 +39,7 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: - sudo apt install -y cmake ninja-build clang lld git - ./build_tools/scripts/git/update_runtime_submodules.sh + run: sudo apt install -y cmake ninja-build clang lld git & ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. @@ -55,7 +53,7 @@ jobs: ./build_tools/pkgci/setup_venv.py ${VENV_DIR} \ --artifact-path=${PACKAGE_DOWNLOAD_DIR} \ --fetch-gh-workflow=${{ inputs.artifact_run_id }} - + sudo apt install -y cmake ninja-build clang lld git - name: Build tests run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin From dfa8804c282985ae21cd008f92c72e45cb1edc0e Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 13:04:06 -0800 Subject: [PATCH 09/21] Add git update Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index c0aa6bafa2fb..9de227b23978 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,7 +39,7 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: sudo apt install -y cmake ninja-build clang lld git & ./build_tools/scripts/git/update_runtime_submodules.sh + run: sudo apt update & sudo apt install -y git & ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. From 2f431fa3698c06704d98b9e3c6d4fe9e485f3a5f Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 14:55:29 -0800 Subject: [PATCH 10/21] Add a new step for dependencies Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 9de227b23978..818f74661976 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -38,8 +38,12 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: submodules: false + - name: "Install depencies" + run: | + sudo apt-get update + sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules - run: sudo apt update & sudo apt install -y git & ./build_tools/scripts/git/update_runtime_submodules.sh + run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. @@ -53,7 +57,6 @@ jobs: ./build_tools/pkgci/setup_venv.py ${VENV_DIR} \ --artifact-path=${PACKAGE_DOWNLOAD_DIR} \ --fetch-gh-workflow=${{ inputs.artifact_run_id }} - sudo apt install -y cmake ninja-build clang lld git - name: Build tests run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin From 5131326340168fee00eb1ca27272674daf3ace1e Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 15:42:13 -0800 Subject: [PATCH 11/21] Make check-yaml happy Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 818f74661976..6ac2d735c73d 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,9 +39,7 @@ jobs: with: submodules: false - name: "Install depencies" - run: | - sudo apt-get update - sudo apt-get install -y cmake ninja-build clang lld git + run: sudo apt-get update & sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 531e9c1a61a7aa0c3fc5949ca03836217fa0dc7e Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 16:09:04 -0800 Subject: [PATCH 12/21] cat apt sources list Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 6ac2d735c73d..cac49db3103d 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,7 +39,7 @@ jobs: with: submodules: false - name: "Install depencies" - run: sudo apt-get update & sudo apt-get install -y cmake ninja-build clang lld git + run: cat /etc/apt/sources.list & sudo apt-get update & sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 65c22228654938fd47ba457ed352623d55ad77bd Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 16:34:25 -0800 Subject: [PATCH 13/21] Fix typo Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index cac49db3103d..bb33503ef668 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -38,8 +38,11 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: submodules: false - - name: "Install depencies" - run: cat /etc/apt/sources.list & sudo apt-get update & sudo apt-get install -y cmake ninja-build clang lld git + - name: "Install dependencies" + run: | + cat /etc/apt/sources.list + sudo apt-get update + sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 9a5a6803ff666b940e9ecb19b2747adb87f9f0f8 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 16:38:05 -0800 Subject: [PATCH 14/21] make pre-commit check-yaml happy Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index bb33503ef668..647a606ed165 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,10 +39,7 @@ jobs: with: submodules: false - name: "Install dependencies" - run: | - cat /etc/apt/sources.list - sudo apt-get update - sudo apt-get install -y cmake ninja-build clang lld git + run: sudo apt-get update && sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 4b3e93f2ebed59f05d9024caae232b88e34aa9da Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 16:41:22 -0800 Subject: [PATCH 15/21] Fix indentition Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 647a606ed165..6cae30f6b154 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -39,7 +39,9 @@ jobs: with: submodules: false - name: "Install dependencies" - run: sudo apt-get update && sudo apt-get install -y cmake ninja-build clang lld git + run: | + sudo apt-get update + sudo apt-get install -y cmake ninja-build clang lld git - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 87867101c5591e4cb001976dd850ba868e6b8b2d Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Tue, 7 Jan 2025 17:27:34 -0800 Subject: [PATCH 16/21] Switch dependency and checkout repo steps Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 6cae30f6b154..8795439073d5 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -34,14 +34,14 @@ jobs: IREE_HIP_ENABLE: 1 IREE_HIP_TEST_TARGET_CHIP: "gfx942" steps: - - name: Check out repository - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - with: - submodules: false - name: "Install dependencies" run: | sudo apt-get update sudo apt-get install -y cmake ninja-build clang lld git + - name: Check out repository + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + with: + submodules: false - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 From 1ed81c05a999c5336308fcfac1580475ae5d1f3b Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 8 Jan 2025 15:10:48 -0800 Subject: [PATCH 17/21] Hack: add git safe.directory Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 8795439073d5..a28300dff4c8 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -43,7 +43,9 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: ./build_tools/scripts/git/update_runtime_submodules.sh + run: | + git config --global --add safe.directory /__w/iree/iree + ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. From 10db4dbd8686f7f11ba7b91d79e4cc19c687a295 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 8 Jan 2025 16:58:55 -0800 Subject: [PATCH 18/21] Add container options to detect rocm Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index a28300dff4c8..54133c752065 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -22,6 +22,7 @@ jobs: runs-on: linux-mi300-gpu-1 container: image: rocm/dev-ubuntu-22.04:6.3 + options: --user root --device=/dev/kfd --device=/dev/dri --ipc=host --group-add video --group-add $render_gid --cap-add=SYS_PTRACE --security-opt seccomp=unconfined env: PACKAGE_DOWNLOAD_DIR: ${{ github.workspace }}/.packages BUILD_DIR: build-tests From df22bcfabe9889cfa5d01c51e8b8b67d8c0efca4 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Wed, 8 Jan 2025 17:19:49 -0800 Subject: [PATCH 19/21] Removed as it was not found Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 54133c752065..41c2f70eed5f 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -22,7 +22,7 @@ jobs: runs-on: linux-mi300-gpu-1 container: image: rocm/dev-ubuntu-22.04:6.3 - options: --user root --device=/dev/kfd --device=/dev/dri --ipc=host --group-add video --group-add $render_gid --cap-add=SYS_PTRACE --security-opt seccomp=unconfined + options: --user root --device=/dev/kfd --device=/dev/dri --ipc=host --group-add video --cap-add=SYS_PTRACE --security-opt seccomp=unconfined env: PACKAGE_DOWNLOAD_DIR: ${{ github.workspace }}/.packages BUILD_DIR: build-tests From 6191b68533ce0913a6bf02222eb0b531cef41025 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Sat, 11 Jan 2025 12:55:04 -0800 Subject: [PATCH 20/21] Remove git add safe-directory as it might not be needed Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 41c2f70eed5f..316242135699 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -44,9 +44,7 @@ jobs: with: submodules: false - name: Check out runtime submodules - run: | - git config --global --add safe.directory /__w/iree/iree - ./build_tools/scripts/git/update_runtime_submodules.sh + run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: # Must match the subset of versions built in pkgci_build_packages. From 3ea1bdf9f202b6a1ffb8492029ba2752366eead9 Mon Sep 17 00:00:00 2001 From: Jodie Su Date: Sat, 11 Jan 2025 13:11:17 -0800 Subject: [PATCH 21/21] Add git.safedirectory back as a step Signed-off-by: Jodie Su --- .github/workflows/pkgci_test_amd_mi300.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pkgci_test_amd_mi300.yml b/.github/workflows/pkgci_test_amd_mi300.yml index 316242135699..5005ca9cfeb1 100644 --- a/.github/workflows/pkgci_test_amd_mi300.yml +++ b/.github/workflows/pkgci_test_amd_mi300.yml @@ -43,6 +43,8 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: submodules: false + - name: "Mark git safe.directory" + run: git config --global --add safe.directory '*' - name: Check out runtime submodules run: ./build_tools/scripts/git/update_runtime_submodules.sh - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0