Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richlist chart #488

Open
F3nixsec opened this issue Apr 15, 2022 · 2 comments
Open

richlist chart #488

F3nixsec opened this issue Apr 15, 2022 · 2 comments

Comments

@F3nixsec
Copy link

have a error in google chrome console
Uncaught ReferenceError: pieWealthDist is not defined
at richlist:79:3
at dispatch (jquery.min.js:3:8066)
at r.handle (jquery.min.js:3:4767)

and distribution in chart dont work

@joeuhren
Copy link
Contributor

A pull request was added 4 years ago that fixes this error by moving the window resize function into the document.ready scope. For some reason it was closed and never merged into the main source. To be honest, I think an easier fix would be to just remove the whole window resize function altogether because replotting the pie chart on window resize seems to do nothing anyway and is probably unnecessary.

https://github.com/iquidus/explorer/pull/155/files

@uaktags
Copy link
Collaborator

uaktags commented May 26, 2022

Looks like the author of that PR closed it himself.
I don't think we have the .resizable parameter set on the pieWealthDist, so I both agree that its probably useless having the variable on the window resize. If we added the resizable, i'd change up the (window).resize and instead just bind it to the event or to the window.onresize and add proper error checking for the variable.

jqPlot is also extremely outdated, and could probably be due for an upgrade to something like chart.js or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants