Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks Page not Loading #391

Open
justthedoctor opened this issue Jun 30, 2020 · 11 comments · May be fixed by #363
Open

Blocks Page not Loading #391

justthedoctor opened this issue Jun 30, 2020 · 11 comments · May be fixed by #363

Comments

@justthedoctor
Copy link

justthedoctor commented Jun 30, 2020

http://server1.cryptodepot.org:3002/blocks <- the blocks page sits for a lil while and then says no data available in the table, I'm not sure whats going on but http://server1.cryptodepot.org:3002/ has the blocks no problem.. Any idea's on what to check for?

@TheHolyRoger
Copy link
Collaborator

Pandacoin are using a custom fork, there is no /blocks page on iquidus (yet) - but it is planned.

@TheHolyRoger TheHolyRoger added this to the Latest Blocks page milestone Jul 19, 2020
@TheHolyRoger TheHolyRoger reopened this Jul 19, 2020
@TheHolyRoger TheHolyRoger linked a pull request Jul 19, 2020 that will close this issue
@justthedoctor
Copy link
Author

justthedoctor commented Jul 19, 2020

http://server1.cryptodepot.org:3003/blocks see this page.. Problem started recently when i set up a new explorer with sendrawtransaction, txinfo and listunspent additions. Now i get https://server1.cryptodepot.org:3001/blocks even after syncing.

@TheHolyRoger
Copy link
Collaborator

@justthedoctor those "additions" aren't in the main repo and aren't supported, that's your problem.

If you link them here in this thread we'll look into incorporating them

@justthedoctor
Copy link
Author

sparklecoin@e7123ba <-- here is the link i followed, i did have to make one change to the code and put sendrawtransaction on the not heavy access line.

@TheHolyRoger
Copy link
Collaborator

There's no "/blocks" page in that commit so I still don't know where you're getting that code from...

We'll look into implementing the other the functions like listunspent and sendrawtx, but there are security considerations to deal with.

For example in that commit, this line is a pretty big vulnerability waiting to be abused: sparklecoin@e7123ba#diff-0364f57fbff2fabbe941ed20c328ef1aR58

@uaktags
Copy link
Collaborator

uaktags commented Jul 20, 2020

At the very least, give us the proper forks you followed:

https://github.com/justthedoctor/explorer

While the functionality is interesting, and as HolyRoger said, we may incorporate it in the future (why couldnt these guys have done a PR in the past), it's not a supported feature at this time.

@uaktags
Copy link
Collaborator

uaktags commented Jul 20, 2020

https://github.com/Whitecoin-org/explorer appears to be the best fork with the original changes.

@justthedoctor
Copy link
Author

https://github.com/justthedoctor/explorer does not have the addition to it, sparklecoin@e7123ba#diff-0364f57fbff2fabbe941ed20c328ef1aR58 is the commit i followed to add to my explorer, but again.. Nothing done in this change should effect the /blocks page, ALSO the cron doesnt run at all, i get a error when doing node scripts/sync.js index update from a cron.. i've tried with the method on the readme and with creating a sh file and executing that,

@TheHolyRoger
Copy link
Collaborator

@uaktags thanks I'll dig into whitecoin code

@justthedoctor you're using a highly modified fork of an old and unsupported version of iquidus, I don't know what else to say until we've actually implemented the functionality you want.

Will leave this issue open and update it when a /blocks page etc is added to the main repo.

We're actively reviewing all PRs at the moment so alternatively you could also ask the Devs of the code you're using to get involved and help out on THIS repo where we're attempting to make a "one fits all" template block explorer rather than hack-and-slash to work ;)

@justthedoctor
Copy link
Author

@TheHolyRoger - The explorer i am running, was a git clone of this repo modified with just the txinfo, sendtransaction and txinfo.

@uaktags
Copy link
Collaborator

uaktags commented Jul 22, 2020

Except, this repo doesn't have /blocks page, so there's a bit more modified than just those three things.
sparklecoin/explorer@e7123ba#diff-0364f57fbff2fabbe941ed20c328ef1aR58 also doesn't include anything for a "blocks" page. So neither iquidus nor your referenced sparklecoin diff contain the page that you're claiming doesn't load. So, again, there's nothing we can do to help with this feature as it's not created or maintained by us.

If you want a blocks page, like the one you're using in your own repo branches but not using in your explorer that's running, you'll have to build it and support it in the interim until we either create one ourselves or accept a PR to merge. Or you can reach out to the devs that created it in the first place....which wasn't us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants