[BUG] Cumulus templates do not bring up L2-only interfaces

[jbemmel]

When extending 31-vlan-bridge-trunk.yml with untagged ports:

links:
- s1:
  s2:
  vlan.trunk: [ red, blue ]

- s1:
    ipv4: False
  h5:
  prefix:
    ipv4: 172.31.1.0/24
- s2:
    ipv4: False
  h6:
  prefix:
    ipv4: 172.31.1.0/24

swp2 on each Cumulus device doesn't come up

Fix: move

netlab/netsim/ansible/templates/initial/cumulus.j2

Line 76 in d07e481

{% if l.ipv4 is defined %}

a few lines down, just before if l.ipv4 == True

We'd probably also want to disable ipv6 on l2-only interfaces

[jbemmel]

Note that FRR does not have this issue due to

netlab/netsim/ansible/templates/initial/frr.j2

Line 132 in d07e481

no shutdown

It might be better to uncomment

netlab/netsim/ansible/templates/initial/cumulus.j2

Line 140 in d07e481

! no shutdown

- it does make a difference, as 'no shutdown' brings the interface up (but still doesn't configure the MTU)

[ipspace]

I agree that it's not nice that the interfaces are not brought up, but as you didn't configure anything on them, it's not a big problem anyway ;)

[ipspace]

Also, the minimum topology to reproduce the problem has nothing to do with VLANs or trunks:

---
nodes:
  s1:
    device: cumulus
  h:
    device: linux

links:
- s1:
    ipv4: False
  h:

[jbemmel]

I agree that it's not nice that the interfaces are not brought up, but as you didn't configure anything on them, it's not a big problem anyway ;)

In this case it was, because the test passes if the ping fails - and with the interface down, the ping will fail regardless if there is an issue with untagged packets being forwarded on the trunk

[ipspace]

2f4a6a1 documents that you need extra configuration to make use of the L2-only interfaces without VLAN module. This became a WAD