Merge pull request #22 from ipfs/countervec3

CounterVec: even more ergonomic
ipfs · Feb 19, 2025 · c39372e · c39372e
2 parents 126a256 + 1534fc5
commit c39372e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/interface.go b/interface.go
@@ -12,11 +12,9 @@ type Counter interface {
 	Add(float64) // Only positive
 }
 
-type Labels map[string]string
-
 // CounterVec is a counter with tags.
 type CounterVec interface {
-	With(Labels) Counter
+	WithLabelValues(lvs ...string) Counter
 }
 
 // Gauge is a metric that can be increased and decreased.
@@ -48,7 +46,7 @@ type SummaryOpts struct {
 // Creator can be used to create different types of metrics.
 type Creator interface {
 	Counter() Counter
-	CounterVec() CounterVec
+	CounterVec(labelNames []string) CounterVec
 	Gauge() Gauge
 	Histogram(buckets []float64) Histogram
 

diff --git a/noop.go b/noop.go
@@ -27,7 +27,7 @@ func (g *noop) Observe(v float64) {
 	// Noop
 }
 
-func (g *noop) With(labels Labels) Counter {
+func (g *noop) WithLabelValues(lvs ...string) Counter {
 	return g
 }
 
@@ -37,7 +37,7 @@ func (g *noop) Counter() Counter {
 	return g
 }
 
-func (g *noop) CounterVec() CounterVec {
+func (g *noop) CounterVec(lvs []string) CounterVec {
 	return g
 }
 

diff --git a/version.json b/version.json
@@ -1,3 +1,3 @@
 {
-  "version": "v0.2.0"
+  "version": "v0.3.0"
 }