Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

dag.get for cid with codec not dag-pb or dag-cbor never calls callback #747

Closed
alanshaw opened this issue Apr 22, 2018 · 4 comments · May be fixed by #755
Closed

dag.get for cid with codec not dag-pb or dag-cbor never calls callback #747

alanshaw opened this issue Apr 22, 2018 · 4 comments · May be fixed by #755
Assignees
@alanshaw
Labels
difficulty:easy P2 - Medium

Comments

@alanshaw
Copy link
Contributor

https://github.com/ipfs/js-ipfs-api/blob/563baa3c2204e266755a70c22978e01ac4bd6d41/src/dag/get.js#L42-L49

I have a git-raw CID. What should happen? Callback with error? Related to #738?
@magik6k
Copy link
Contributor

magik6k commented Apr 22, 2018

Yep, this will be fixed with #738

@alanshaw
Copy link
Contributor Author

ok, shall we fix for now by calling back with an error?

@daviddias
Copy link
Contributor

@alanshaw 👍 agreed, it should notify the user that is not supported yet.

@alanshaw alanshaw mentioned this issue May 3, 2018
Open
@ghost ghost assigned alanshaw May 3, 2018
@ghost ghost added the in progress label May 3, 2018
@daviddias
Copy link
Contributor

Work happening here #755

@ghost ghost removed the in progress label Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
difficulty:easy P2 - Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] feat(dag): add IPLD to dag.get ipfs-inactive/js-ipfs-http-client
3 participants
@alanshaw @daviddias @magik6k