Highlight bug: eql? is not aliased to the overridden ==.

~~~ IPAddress.parse('::1') == IPAddress.parse('::1') #=> true IPAddress.parse('::1').eql? IPAddress.parse('::1') #=> false ~~~
ipaddress-gem · Mar 19, 2016 · c983123 · c983123
1 parent 064502c
commit c983123
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/test/ipaddress/ipv4_test.rb b/test/ipaddress/ipv4_test.rb
@@ -361,8 +361,10 @@ def test_method_compare
     assert_equal false, ip3 < ip1
     # ip1 should be equal to itself
     assert_equal true, ip1 == ip1
+    assert_equal true, ip1.eql?(ip1)
     # ip1 should be equal to ip4
     assert_equal true, ip1 == ip4
+    assert_equal true, ip1.eql?(ip4)
     # test sorting
     arr = ["10.1.1.1/8","10.1.1.1/16","172.16.1.1/14"]
     assert_equal arr, [ip1,ip2,ip3].sort.map{|s| s.to_string}

diff --git a/test/ipaddress/ipv6_test.rb b/test/ipaddress/ipv6_test.rb
@@ -247,6 +247,11 @@ def test_method_compare
     assert_equal false, ip3 < ip1
     # ip1 should be equal to itself
     assert_equal true, ip1 == ip1
+    assert_equal true, ip1.eql?(ip1)
+    # ip1 should be equal to a copy of itself
+    other = ip1.dup
+    assert_equal true, ip1 == other
+    assert_equal true, ip1.eql?(other)
     # ip4 should be greater than ip1
     assert_equal true, ip1 < ip4
     assert_equal false, ip1 > ip4