Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Stop solidifying when asking for previously pruned transactions #1371

Open
GalRogozinski opened this issue Mar 12, 2019 · 1 comment · May be fixed by #1418
Open

Stop solidifying when asking for previously pruned transactions #1371

GalRogozinski opened this issue Mar 12, 2019 · 1 comment · May be fixed by #1418
Assignees
Labels
C-Consensus P2 - High Priority - Prefer Merging This

Comments

@GalRogozinski
Copy link
Contributor

GalRogozinski commented Mar 12, 2019

Description

While solidifying transactions we might start requesting old transactions that have been pruned.
We want to stop once we recognize this.

Motivation

Optimization

Requirements

  1. When we check solidity and we encounter a tx that is in the Cuckoo filter we set a deletedScore to 1.
    We don't persist the tx but save it in local memory
  2. We start to recursively request its parents and if they are also in the cuckoo filter increment deletedProbability.
  3. If we reach a score of 10 we abort.
  4. If we find one parent that is not in the cuckoo filter we assume that the rest are false positives.

Open Questions (optional)

Do we need to clear the cuckoo filter of extremely old txs in order to decrease false positive rates?

@GalRogozinski GalRogozinski added C-Consensus P2 - High Priority - Prefer Merging This labels Mar 12, 2019
@kwek20 kwek20 self-assigned this Apr 16, 2019
@kwek20 kwek20 linked a pull request Apr 24, 2019 that will close this issue
6 tasks
@jakubcech
Copy link
Contributor

Putting this back to backlog until we pick it up again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Consensus P2 - High Priority - Prefer Merging This
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants