Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Clarification on QC Checks Implemented in argo.py #112

Open
Sakshamgupta90 opened this issue Jun 3, 2024 · 1 comment
Open

GSoC: Clarification on QC Checks Implemented in argo.py #112

Sakshamgupta90 opened this issue Jun 3, 2024 · 1 comment
Labels

Comments

@Sakshamgupta90
Copy link
Contributor

Hi, @ocefpaf @MathewBiddle @mwengren
As I delve deeper into the project, I want to clarify that the current state of QC checks for the glider data are implemented in the argo.py file right? Specifically, I am referring to the speed test and pressure increasing test for glider data.

  • Are these the only QC checks implemented in the argo.py file?
  • If not, could you please provide a brief overview of the other QC checks?

Your guidance will help me understand the current implementation better and identify areas for improvement.

@ocefpaf ocefpaf added the GSoC24 label Jun 5, 2024
@ocefpaf
Copy link
Member

ocefpaf commented Jun 13, 2024

They are probably the same, if not very close with different defaults that we can factor in and re-use the same function.

Here we are in a complicated territory b/c we don't want to change the API but we also don't want to have a lot of code duplication. Soo we will also have another moving platform to deal with, animal telemetry, that will have similar test.

With that said, here is a suggestion, we could create a new module named moving_platforms.py, move these common tests there, and import them into the argo.py module to avoid breakage but also keeping them available in for other modules to import from.

What do you think @iwensu0313?

PS: Note that, all the glider tests you will implement, should probably go into the qartod.py module b/c they are part of qartod. That means anything you implement in this new moving_platforms.py, should be imported that as well and added to the __all__ variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants