Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fixes lazy #27

Open
deviousasti opened this issue Aug 17, 2020 · 0 comments
Open

Make fixes lazy #27

deviousasti opened this issue Aug 17, 2020 · 0 comments

Comments

@deviousasti
Copy link

Analyzers will produce a number of warnings, but only when a code-fixes request (from the suggestions API) is made do we actually need a list of fixes.

In the interest of performance, we should try to change the fixes from Fix list to Lazy<Fix list>.

This is already how suggestions in FSharpLint are implemented.
https://github.com/fsprojects/FSharpLint/blob/f58665fc8c48461ad3d486bf608e4233012a94c0/src/FSharpLint.Core/Framework/Suggestion.fs#L28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deviousasti