Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect or incomplete information for "importing the dist library" #933

Open
mrtnmgs opened this issue Nov 14, 2022 · 0 comments
Open

Comments

@mrtnmgs
Copy link
Contributor

mrtnmgs commented Nov 14, 2022

https://github.com/ionic-team/stencil-site/blob/master/src/docs/output-targets/dist.md

The last 2 paragraphs on the Output Targets > dist page are identical, and either incorrect or incomplete. They state:
"Add an import within the root component: import my-component;"
What is the root component? Are we talking about importing a component within another one? If so it seems out of place in this section which deals with distribution of the package / components.
I'm not sure it's actually what this paragraph is about, since afaik components are available from another component without having to import them.
If it's a javascript import declaration it's missing quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant