From f974adf37dd42326ddf4c93d9b3a22af7682a11c Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 12 Dec 2023 10:04:54 -0500 Subject: [PATCH 1/3] chore: deprecate the ssl command --- packages/@ionic/cli/src/commands/ssl/generate.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/@ionic/cli/src/commands/ssl/generate.ts b/packages/@ionic/cli/src/commands/ssl/generate.ts index 485923bc1b..73feae1f05 100644 --- a/packages/@ionic/cli/src/commands/ssl/generate.ts +++ b/packages/@ionic/cli/src/commands/ssl/generate.ts @@ -45,7 +45,7 @@ export class SSLGenerateCommand extends SSLBaseCommand implements CommandPreRun return { name: 'generate', type: 'project', - summary: 'Generates an SSL key & certificate', + summary: 'Generates an SSL key & certificate (Deprecated)', // TODO: document how to add trusted certs description: ` Uses OpenSSL to create a self-signed certificate for ${strong('localhost')} (by default). @@ -53,6 +53,8 @@ Uses OpenSSL to create a self-signed certificate for ${strong('localhost')} (by After the certificate is generated, you will still need to add it to your system or browser as a trusted certificate. The default directory for ${input('--key-path')} and ${input('--cert-path')} is ${input('.ionic/ssl/')}. + +Deprecated. Developers should generate an SSL certificate locally and then configure it using their project tooling such as Vite or Angular CLI. `, options: [ { From 0c1c6b369abdd19900aee276e8620dd33e41aa1c Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 12 Dec 2023 11:23:00 -0500 Subject: [PATCH 2/3] use deprecated group --- packages/@ionic/cli/src/commands/ssl/generate.ts | 4 ++-- packages/@ionic/cli/src/commands/ssl/index.ts | 2 +- packages/@ionic/cli/src/lib/project/angular/serve.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/@ionic/cli/src/commands/ssl/generate.ts b/packages/@ionic/cli/src/commands/ssl/generate.ts index 73feae1f05..acb1a3e595 100644 --- a/packages/@ionic/cli/src/commands/ssl/generate.ts +++ b/packages/@ionic/cli/src/commands/ssl/generate.ts @@ -45,7 +45,7 @@ export class SSLGenerateCommand extends SSLBaseCommand implements CommandPreRun return { name: 'generate', type: 'project', - summary: 'Generates an SSL key & certificate (Deprecated)', + summary: 'Generates an SSL key & certificate', // TODO: document how to add trusted certs description: ` Uses OpenSSL to create a self-signed certificate for ${strong('localhost')} (by default). @@ -112,7 +112,7 @@ Deprecated. Developers should generate an SSL certificate locally and then confi groups: [MetadataGroup.ADVANCED], }, ], - groups: [MetadataGroup.EXPERIMENTAL], + groups: [MetadataGroup.DEPRECATED], }; } diff --git a/packages/@ionic/cli/src/commands/ssl/index.ts b/packages/@ionic/cli/src/commands/ssl/index.ts index 89fb4bf472..21988e0309 100644 --- a/packages/@ionic/cli/src/commands/ssl/index.ts +++ b/packages/@ionic/cli/src/commands/ssl/index.ts @@ -8,7 +8,7 @@ export class SSLNamespace extends Namespace { return { name: 'ssl', summary: 'Commands for managing SSL keys & certificates', - groups: [MetadataGroup.EXPERIMENTAL], + groups: [MetadataGroup.DEPRECATED], description: ` These commands make it easy to manage SSL certificates for using HTTPS with ${input('ionic serve')}. `, diff --git a/packages/@ionic/cli/src/lib/project/angular/serve.ts b/packages/@ionic/cli/src/lib/project/angular/serve.ts index 21f75d27c9..27095d48db 100644 --- a/packages/@ionic/cli/src/lib/project/angular/serve.ts +++ b/packages/@ionic/cli/src/lib/project/angular/serve.ts @@ -56,7 +56,7 @@ The dev server can use HTTPS via the ${input('--ssl')} option ${chalk.bold.red(' name: 'ssl', summary: 'Use HTTPS for the dev server', type: Boolean, - groups: [MetadataGroup.EXPERIMENTAL, 'cordova'], + groups: [MetadataGroup.DEPRECATED, 'cordova'], hint: weak('[ng]'), }, { From 5480ba2692ea5b7b2092bc86705063448e234735 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 12 Dec 2023 11:45:11 -0500 Subject: [PATCH 3/3] Update serve.ts --- packages/@ionic/cli/src/lib/project/angular/serve.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@ionic/cli/src/lib/project/angular/serve.ts b/packages/@ionic/cli/src/lib/project/angular/serve.ts index 27095d48db..21f75d27c9 100644 --- a/packages/@ionic/cli/src/lib/project/angular/serve.ts +++ b/packages/@ionic/cli/src/lib/project/angular/serve.ts @@ -56,7 +56,7 @@ The dev server can use HTTPS via the ${input('--ssl')} option ${chalk.bold.red(' name: 'ssl', summary: 'Use HTTPS for the dev server', type: Boolean, - groups: [MetadataGroup.DEPRECATED, 'cordova'], + groups: [MetadataGroup.EXPERIMENTAL, 'cordova'], hint: weak('[ng]'), }, {