Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug grab bag for table #466

Open
berycz opened this issue Sep 21, 2023 · 0 comments
Open

bug grab bag for table #466

berycz opened this issue Sep 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@berycz
Copy link
Contributor

berycz commented Sep 21, 2023

  • columns__select__header__attrs__class = {"text-center": True} doesn't work for me for some reason 🤔 <th> wont get the class
    weird is, that columns__select__header__attrs__title = "Foo" works

  • FIXED: 'Select all' not translated in style_*.py

  • bs5 could have <i class="bi bi-check-square"></i>, so no need for Font Awesome

  • FIXED: js_select_all.html isnt translated

  • js_select_all.html could go into iommi.js, I'm just not sure, how to deal with js translates (django way, or custom window.iommi.translates)

FIXED: also I'd drop the IE11 support in js_select_all.html, useless piece of code :)

@boxed boxed changed the title bulk select bug grab bag for table Sep 21, 2024
@boxed boxed added the bug Something isn't working label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants