Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Maintenance overview diagrams #85

Open
VladimirAlexiev opened this issue May 21, 2024 · 0 comments
Open

improve Maintenance overview diagrams #85

VladimirAlexiev opened this issue May 21, 2024 · 0 comments
Assignees

Comments

@VladimirAlexiev
Copy link

@mhodki

  • The stereotype (C) for classes is IMHO unnecessary (can just use (i) for instances)

https://github.com/iofoundry/ontology/blob/master/maintenance/images/fmea_ontology.png

  • Subclass arrow directions are inconsistent, better should all go upward
  • IMHO "only" should be renamed to "all"

https://github.com/iofoundry/ontology/blob/master/maintenance/images/MaintenanceDevRelationships.png

  • The diagram is too wide, some tweaking and "left to right direction" may fix this
  • The arrow style is different from "fmea" (that style is better)

https://github.com/iofoundry/ontology/blob/master/maintenance/images/maintenancestate.png

  • shows 2 empty compartments per class: "hide empty members" should fix that

If you post the plantuml sources, I'll try to improve them. You can extract them as follows:

plantuml -metadata fmea-malfunction-rule.png
------------------------
fmea-malfunction-rule.png

@startuml
skinparam classFontSize 16
skinparam shadowing false
hide empty members

skinparam class {
        backgroundColor<<ISO 15926>> LightCyan
        backgroundColor<<Functional System>> White
        backgroundColor<<FMEA>> LightYellow
        backgroundColor<<Asset>> PeachPuff
}


class Disposition as "Disposition" <<ISO 15926>>

class Component as "Component" <<Functional System>>
class FailureDueToOverCurrent as "FailureDueToOverCurrent" <<Functional System>>

class FailureEvent as "FailureEvent" <<FMEA>>
class Malfunction as "Malfunction" <<FMEA>>
class ObjectInFaultState as "ObjectInFaultState" <<FMEA>>

class Heater as "Heater" <<Asset>>


class heaters as "heaters" <<Asset>> <<(i,#EE82EE)>>
class heaters_shortcircuit_malfunction as "heaters malfunction\ndue to overcurrent" <<Asset>> <<(i,#EE82EE)>>
class failure_event_heaters_shortcircuit as "heaters overcurrent\nfailure event" <<Asset>> <<(i,#EE82EE)>>


Heater -up-|> Component

Malfunction -up-|> Disposition

FailureDueToOverCurrent -up-|> FailureEvent

heaters -up-> Heater : "?"
heaters -[#black]right-> heaters_shortcircuit_malfunction : "hasMalfunction"
heaters -[#blue]down-> "?\ninferred" ObjectInFaultState

heaters_shortcircuit_malfunction -[#black]right-> failure_event_heaters_shortcircuit : "realizedIn"
heaters_shortcircuit_malfunction -up-> Malfunction : "?"

failure_event_heaters_shortcircuit -up-> FailureDueToOverCurrent : "?"
@enduml

PlantUML version 1.2020.01beta5(Unknown compile time)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants