From a95db6e519fa39cf067de61fea5bdaf2b975164f Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Thu, 27 Feb 2025 11:42:19 +0000 Subject: [PATCH 1/4] fix increment not defined --- packages/database/lib/modular/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/database/lib/modular/index.js b/packages/database/lib/modular/index.js index bab6387d2d..90cdf2f770 100644 --- a/packages/database/lib/modular/index.js +++ b/packages/database/lib/modular/index.js @@ -1,4 +1,5 @@ import { getApp } from '@react-native-firebase/app'; +import { firebase } from ".."; /** * @typedef {import("..").FirebaseApp} FirebaseApp From 771b0676d2cd74346482c5c40ee38c2db91308bb Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Thu, 27 Feb 2025 11:46:10 +0000 Subject: [PATCH 2/4] comment --- packages/database/lib/modular/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/database/lib/modular/index.js b/packages/database/lib/modular/index.js index 90cdf2f770..bb8dcec013 100644 --- a/packages/database/lib/modular/index.js +++ b/packages/database/lib/modular/index.js @@ -1,5 +1,5 @@ import { getApp } from '@react-native-firebase/app'; -import { firebase } from ".."; +import { firebase } from ".."; // Needed for increment() method /** * @typedef {import("..").FirebaseApp} FirebaseApp From f06528a64bbcf3489e6a1f3df997f3a6f0b5fd41 Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Thu, 27 Feb 2025 12:06:37 +0000 Subject: [PATCH 3/4] formatting --- packages/database/lib/modular/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/database/lib/modular/index.js b/packages/database/lib/modular/index.js index bb8dcec013..821d0effa0 100644 --- a/packages/database/lib/modular/index.js +++ b/packages/database/lib/modular/index.js @@ -1,5 +1,5 @@ import { getApp } from '@react-native-firebase/app'; -import { firebase } from ".."; // Needed for increment() method +import { firebase } from '..'; // Needed for increment() method /** * @typedef {import("..").FirebaseApp} FirebaseApp From 05e0ac4659418b079578fd9c9d4d9c8bf24eb897 Mon Sep 17 00:00:00 2001 From: "jude.kwashie" Date: Tue, 4 Mar 2025 14:10:15 +0000 Subject: [PATCH 4/4] chore: import ServerValue directly --- packages/database/lib/modular/index.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/database/lib/modular/index.js b/packages/database/lib/modular/index.js index 821d0effa0..a5826c5aeb 100644 --- a/packages/database/lib/modular/index.js +++ b/packages/database/lib/modular/index.js @@ -1,5 +1,7 @@ import { getApp } from '@react-native-firebase/app'; -import { firebase } from '..'; // Needed for increment() method +import DatabaseStatics from '../DatabaseStatics'; + +const { ServerValue } = DatabaseStatics; /** * @typedef {import("..").FirebaseApp} FirebaseApp @@ -110,7 +112,7 @@ export function getServerTime(db) { * @returns {object} */ export function serverTimestamp() { - return firebase.database.ServerValue.TIMESTAMP; + return ServerValue.TIMESTAMP; } /** @@ -118,7 +120,7 @@ export function serverTimestamp() { * @returns {object} */ export function increment(delta) { - return firebase.database.ServerValue.increment(delta); + return ServerValue.increment(delta); } export * from './query';