Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] ensureInitialized also calls fetchAndActivate #8001

Open
RohovDmytro opened this issue Aug 31, 2024 · 1 comment
Open

[🐛] ensureInitialized also calls fetchAndActivate #8001

RohovDmytro opened this issue Aug 31, 2024 · 1 comment
Labels

Comments

@RohovDmytro
Copy link

RohovDmytro commented Aug 31, 2024

Issue

  1. Calling ensureInitialized on startup

  2. The doc states it ensures the initialization, but the codebase suggests it also fetches and activates data:

image

In my usecase that leads to performance issues.

Is this an intended behaviour?

@russellwheatley
Copy link
Member

Hey @RohovDmytro - that is a good question. This was implemented 4 years ago but I'm not sure why we have this within essureInitialized, we don't have it for iOS. I would be inclined to remove it but there may be developers relying on it to fetch and activate remote config. I'll label this a breaking change, and when we get around to the breaking change (we're planning one in the future), I'll propose we remove this 🙏

@mikehardy mikehardy changed the title [🐛] essureInitialized also calls fetchAndActivate [🐛] ensureInitialized also calls fetchAndActivate Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants