Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting an object with a .then property which is not a promise resolves to undefined #1570

Open
brahms116 opened this issue May 30, 2024 · 0 comments

Comments

@brahms116
Copy link

brahms116 commented May 30, 2024

When you inject an object with a property of .then but its not a promise, it resolves to undefined. This is because when resolving it believes that its a promise when its not

Expected Behavior

This should pass...

import { expect } from "chai";
import { Container, inject, injectable } from "../../src/inversify";

describe("Issue", () => {
  it("It should not return injected value as undefined if the value contains a .then property but it is not a promise", () => {
    const container = new Container();

    interface Injected {
      myProperty: string;
      then: () => number;
    }

    @injectable()
    class ResolveMe {
      constructor(@inject("Injected") public injected: Injected) {}
    }

    container.bind("Injected").toConstantValue({
      myProperty: "myNewProperty",
      then: () => 1
    });

    const me = container.resolve(ResolveMe);
    expect(me.injected.myProperty).to.eql("myNewProperty");
  });
});

Current Behavior

injected resolves to undefined

Possible Solution

I have linked a PR for a possible approach #1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant