Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Re-Implement customize options #8969

Merged
merged 10 commits into from
Jan 31, 2025
Merged

feat: Re-Implement customize options #8969

merged 10 commits into from
Jan 31, 2025

Conversation

matmair
Copy link
Member

@matmair matmair commented Jan 27, 2025

Add customisation options back
grafik
grafik

Fixes #8818

@matmair matmair added enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface labels Jan 27, 2025
@matmair matmair added this to the 1.0.0 milestone Jan 27, 2025
@matmair matmair self-assigned this Jan 27, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 71f4c09
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/679a9f2b7c5dee00083464b4

@matmair matmair mentioned this pull request Jan 27, 2025
Open
3 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (edc97b1) to head (71f4c09).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/pages/Auth/Login.tsx 64.28% 2 Missing and 3 partials ⚠️
src/frontend/src/components/nav/Header.tsx 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8969   +/-   ##
=======================================
  Coverage   85.23%   85.24%           
=======================================
  Files        1176     1176           
  Lines       51935    51959   +24     
  Branches     2108     2111    +3     
=======================================
+ Hits        44268    44290   +22     
- Misses       7134     7140    +6     
+ Partials      533      529    -4
Flag Coverage Δ
backend 86.93% <100.00%> (+<0.01%) ⬆️
pui 69.17% <68.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair
Copy link
Member Author

matmair commented Jan 29, 2025

@SchrodingersGat @wolflu05 any thoughts on this?

@wolflu05
Copy link
Contributor

I really like it, thanks for implementing.

@matmair matmair changed the title [FR] Re-Implement customize options feat: Re-Implement customize options Jan 29, 2025
@matmair
Copy link
Member Author

matmair commented Jan 30, 2025

@SchrodingersGat ready for review and merge

@SchrodingersGat
Copy link
Member

@matmair nice work :)

@SchrodingersGat SchrodingersGat merged commit cfa248a into inventree:master Jan 31, 2025
27 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue8818 branch January 31, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingersGat SchrodingersGat SchrodingersGat approved these changes

Assignees

@matmair matmair

Labels
enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[FR] Re-Implement customize options
3 participants
@matmair @wolflu05 @SchrodingersGat