-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidation from == method #174
Comments
Probably is safe to update these to be: Base.:(==)(a::T, b::Endpoint::T) where T = a == b.endpoint && isclosed(b)
Base.:(==)(a::Endpoint{T}, b::T) where T = b == a Not quite as general but probably covers our needs |
Got another one: inserting convert(::Type{T}, interval::Intervals.AnchoredInterval{P, T, L, R} where {L<:Intervals.Bounded, R<:Intervals.Bounded}) where {P, T} in Intervals at /home/mbesancon/.julia/packages/Intervals/ua9cq/src/anchoredinterval.jl:181 invalidated: this one was huge with 311 invalidated signatures |
Good news. That method is already deprecated: Intervals.jl/src/anchoredinterval.jl Lines 186 to 191 in 0513348
|
perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Same flavour as #144, I discovered the invalidation in a downstream package:
(this is on Intervals 1.5.0)
The text was updated successfully, but these errors were encountered: