BUG: generate valid EBMModel when merging
#578
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Signed-off-by: DerWeh <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #578 +/- ##
========================================
Coverage 75.68% 75.69%
========================================
Files 72 72
Lines 9078 9102 +24
========================================
+ Hits 6871 6890 +19
- Misses 2207 2212 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yes, @DerWeh, this approach looks great. Let me know when you feel it's ready to be merged. |
paulbkoch
force-pushed
the
develop
branch
6 times, most recently
from
f8501a4 to
e0369a7
Compare
paulbkoch
force-pushed
the
develop
branch
5 times, most recently
from
50d4254 to
5e999b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix #576. Upon merging, we average numerical parameters.
I would add a warning to the documentation, that we do not guarantee that EBMs produced by
merge_ebmscan be fitted. You often allow for so many different types of arguments, that hardly can catch every edge case meaningfully.@paulbkoch please take a look at
_initialize_ebm. Is this how you imagine handling the parameters? I would appreciate some early feedback. If this is in general what you have in mind, I'll try cleaning up the code some more. But it's quite messy, as your API is so flexible.TODO
monotonizeandexclude