Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Subject #9721

Open
bitnapper opened this issue Aug 10, 2024 · 6 comments
Open

Renaming Subject #9721

bitnapper opened this issue Aug 10, 2024 · 6 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@bitnapper
Copy link

Problem

Many subject have multiple different duplicate, e.g. Ernest Rutherford (1871-1937), Rutherford, ernest, 1871-1937

Subject page has an edit button that could be facilitated to rename that subject in any edition

image

Example:

Go to subject page Rutherford, ernest, 1871-1937, Edit-Button, change title from Rutherford, ernest, 1871-1937 to person:Ernest Rutherford (1871-1937), save button.

After saving, the subject should be changed in all edition with the former subject.

Proposal & Constraints

What is the proposed solution / implementation?

see above.

Is there a precedent of this approach succeeding elsewhere?

not to my knowledge.

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@bitnapper bitnapper added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Aug 10, 2024
@AbhinavKRN
Copy link

@bitnapper Can you assign this issue to me?

@bitnapper
Copy link
Author

@bitnapper Can you assign this issue to me?

@AbhinavKRN I'm sorry, I don't have any special permissions to do that. I guess @mekarpeles can do that?

@charanbhatia
Copy link

@mekarpeles @gojomo can you assign this issue to me? I can easily solve this issue and raise the PR soon !!

@tfmorris
Copy link
Contributor

I would recommend waiting until the issue is triaged to see what they'd like the solution to be. Personally, I think the right solution is to make subjects into 1st class objects instead of mere strings, as I suggested in #2819. Then all the different name variants (and different language labels) can get stored as aliases.

@scottbarnes
Copy link
Collaborator

Just chiming in to add that because #9520 / #9643 uses subjects, improvements in subjects (e.g. such as outlined in #2819 and #7904) would probably make the Best Book feature more useful to patrons.

@mekarpeles mekarpeles added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Response Issues which require feedback from lead and removed Needs: Lead labels Aug 12, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Response Issues which require feedback from lead labels Aug 19, 2024
@mekarpeles
Copy link
Member

Related to #7904 and #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

6 participants