Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISBN import from Amazon no longer functioning #10316

Open
stopregionblocking opened this issue Jan 11, 2025 · 2 comments
Open

ISBN import from Amazon no longer functioning #10316

stopregionblocking opened this issue Jan 11, 2025 · 2 comments
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@stopregionblocking
Copy link

Problem

The feature which allows Amazon.com records to be imported into OpenLibrary via searching for ISBNs seems to no longer be working since OL was taken down a couple months ago.

As a test ISBN, try searching 1445232332, then repeating the search. This item is not imported: https://www.amazon.com/World-After-Amazon-Stories-Workers/dp/1445232332

Reproducing the bug

  1. Enter an ISBN present in Amazon.com but not present in OpenLIbrary in the top right search bar, then search.
  2. On the search results page, select the top right search bar again, then run the search with the same ISBN still in the field.
  • Expected behavior: A new book is imported from Amazon.com using the data attached to the ISBN.
  • Actual behavior: The same search results as the first time around are returned.

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@stopregionblocking stopregionblocking added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 11, 2025
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 12, 2025
@mekarpeles
Copy link
Member

We're aware of the issue, it may be some time before it's addressed; needs breakdown before it can be worked on.

@scottbarnes
Copy link
Collaborator

scottbarnes commented Jan 13, 2025

I think this feature will magically start working once both #10313 is merged and the proxy allow list is updated. I am hoping the proxy change will happen tomorrow. This example ISBN is already in the import queue (though it failed because of the cover value and will need to have its status changed:

>>> next(oldb.query("SELECT * FROM import_item WHERE ia_id = 'amazon:1445232332'"))
<Storage {'id': 43923397, 'batch_id': 1270, 'import_time': datetime.datetime(2025, 1, 11, 18, 24, 50, 122576), 'status': 'failed', 'error': 'unknown-error', 'ia_id': 'amazon:1445232332', 'ol_key': None, 'comments': None, 'added_time': datetime.datetime(2025, 1, 11, 18, 12, 52, 498486), 'data': '{"authors": [], "contributors": [], "cover": "https://m.media-amazon.com/images/I/31keKdI014L._SL500_.jpg", "full_title": "The World After Amazon : Stories from Amazon Workers", "isbn_10": ["1445232332"], "isbn_13": ["9781445232331"], "notes": "Source title: The World After Amazon: Stories from Amazon Workers", "number_of_pages": 237, "physical_format": "paperback", "publish_date": "Aug 20, 2024", "publishers": ["Lulu.com"], "source_records": ["amazon:1445232332"], "subtitle": "Stories from Amazon Workers", "title": "The World After Amazon"}', 'submitter': None}>

But this should show that things are being queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

3 participants