Refactor IdentifiersInput Vue component to not need isEdition
checks
#10301
Labels
Lead: @cdrini
Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]
Priority: 3
Issues that we can consider at our leisure. [managed]
Type: Refactor/Clean-up
Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
I think we can remove all the references to
isEdition
(or similar) from this code. Most of the logic was just checking forsaveIdentifiersAsList
, and now that that abstraction has come out, I think these can be cleared up as well! Instead ofedition_popular
, we can just have apopular_ids="['project_gutenberg', 'isbn']"
and so on. This doesn't have to be edition-specific, and can just be a list of identifiers to be extracted from the pool of identifiers to be listed at the top. And then you can just check if there are any popular identifiers.(Addendum of #10032)
Relevant Files
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/components/IdentifiersInput.vue
Stakeholders
@schu96
The text was updated successfully, but these errors were encountered: