-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lint] eslint, prettier setup and respective scripts implemented. #87
Conversation
Hi @muskangupta-iitr , it looks there are some conflicts in package.json, could solve those? |
e73ee9d
to
466ac93
Compare
@AdrianBZG I have rebased the PR. |
@AdrianBZG @Nikhil-Vats I have also added the |
@Nikhil-Vats @AdrianBZG Can you please review this? |
Hi @muskangupta-iitr , as happens in PR100, when I run the dev environment I'm getting this error: `[Browsersync] Watching files... Error: watch node_modules/minimist/test ENOSPC node version: 8.10.0 |
@AdrianBZG |
@muskangupta-iitr it looks like installing those extra packages added too many file handles to the gulp watch command. Try changing this line InterMine-Data-Browser-Tool/gulpfile.js Line 195 in cde544b
To this (remove the wildcard) You may have to add the trailing Ensure that the expected packages are still properly updated, by running |
@muskangupta-iitr Thank you so much for working on this one. 🎉 It's a big one and hence can already be counted as a contribution (feel free to do so). Please be aware - this is a great start! 🚀 💯 I've mentioned quite a few things to improve, but not because it's bad - just because I think we can make it even better. |
@Nikhil-Vats Thanks for reviewing my contribution and suggesting changes to it. I am glad to know them as working on them would improve my learning. I am reading more about linting and the related stuff and will try to update the PR asap. Also, thanks for the appreciation, it really means a lot :) |
@Nikhil-Vats @AdrianBZG I have updated the PR. Please have a look on it. |
Description
Successfully setup
eslint
andprettier
with respective plugins, configurations, ignorefiles and scripts.Related issues and discussion
Fixes #84
@Nikhil-Vats Review!