[add]: autoFocus option added in autocompleted widget #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't work as expected. Please read this comment. Your PR prevents the user from writing free text and instead autocompletes the suggestion from the list of available filters, sometimes even with 3 letters, ex - I just wrote dat and it autocompleted to Antigen processing: Ubiquitination & Proteasome degradation, similarly just writing sig changes to Signal Transduction. Feel free to ask any doubts that you may have. 😃 @AdrianBZG Please correct me if I'm wrong. 😄 |
|
Hi @Nikhil-Vats , @muskangupta-iitr , Yes you are correct, the autocompletion should only be triggered when the user press the "enter" key, which should do two things:
|
|
@AdrianBZG @Nikhil-Vats I will try to implement that and update the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user types anything in the sidebar filters input boxes, user have to select one of the dropdown results in order to search for it. It doesn't work when user press the enter key.
Fixes #49
Solution
We can fix this issue by just enabling one of the options autoFocus:true as per the autocomplete documentation. As the user types anything in the input box, according to search results it will automatically selects the first option and when user press the enter it will be selected.