Notify on errors when loading the default filters

[AdrianBZG]

Sometimes the user get stuck in a mine that is giving errors, without the possibility to continue using the browser. To avoid this, notify that there is a problem and move to HumanMine

[VarunBhandia]

@AdrianBZG sir, can you please give some screenshots or cases that I can try. I will work on this issue.

[Dhruvi16]

Hey! Can I take this up?
Thank you
Dhruvi

[AdrianBZG]

Hi @Dhruvi16 ,

Sure. Ideally we would like to display an error message when there's an error loading the mine when accessing the data browser. In this prompt message it would be ideal to show a dropdown to choose a different mine so that the user doesn't get stuck in a not working one.

[Dhruvi16]

I am not sure how to reproduce this error. Could you please help me with that? I am new to the platform and I am not very familiar with the interface and data. So a little help would be nice.
Thank you
Dhruvi

[AdrianBZG]

@Dhruvi16 Try removing this lines that prevent some mines from appearing as an option, and then select one of them. I'm sure that some are failing for different reasons (missing entities in their schema that we use for the plots/filters, usage of HTTPS #33, etc). There are 3 lines to remove the mine pre-filtering:

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1619

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1622

and

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1625

[Dhruvi16]

Hey! I am sorry for so many doubts but I am only able to see this following window-

I think I am missing something. I am not sure about the filters you mentioned above.
Thank you
Dhruvi.

[AdrianBZG]

@Dhruvi16 First thing I notice is that you probably don't have the latest version of the browser: do a git pull.

About the "mine pre-filtering" I'm talking about:

In your screenshot, there's a dropdown to the left of the "Gene" button. That button gets populated with the mines in the registry.

However, since some mines are not fully compatible with this data browser, I added a filter to not added these in the dropdown when it gets populated, the filters are in this 3 lines:

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1619

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1622

and

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1625

If you remove these lines you'll get the option to choose mines that will make the data browser explode. And that's the case we want to take into account with this issue.

[Dhruvi16]

I got it! I removed the prefiltering. But there is no data.
I am getting this error.

[AdrianBZG]

@Dhruvi16 I think that may be a HumanMine specific error. But anyway that's what we want to handle, when an error occurs, prompt the user to change mine instead.

[sabina-rohman]

Hi, @AdrianBZG I'm an outreachy applicant May 2020. Can I please work on this issue, if it's still open?

[Dhruvi16]

Hey! I am not working on this issue currently so I guess you can go forward with it. Apologies for the delay.
Thank you.

[sabina-rohman]

Hi @Dhruvi16 Thanks for letting me know. Should I wait for @AdrianBZG to assign the issue to me or i just go ahead and fork the repository?
Or can you assign it to me please?

[Dhruvi16]

Oh! I am just a contributor. You should totally wait for @AdrianBZG reply.
Thank you.

[sabina-rohman]

Thanks @Dhruvi16 :)

[AdrianBZG]

Hi @sabina-rohman ,

Yes, sure go ahead, I'll assign it to you :)

[sabina-rohman]

@AdrianBZG Thanks :)

[sabina-rohman]

@AdrianBZG I have setup the project locally and am able to launch it. I looked at removing those three lines you mentioned in one of the above comments. But turns out that in the latest code in common.js, those lines are already commented out.

https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1623
https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1626
https://github.com/intermine/InterMine-Data-Browser-Tool/blob/master/src/js/common.js#L1629

Selecting those specific mines (ModMine or GrapeMine) don't give error any more.

Is there any other way I could simulate the error?

[AdrianBZG]

Hi @sabina-rohman ,

I have changed the title of the issue, since now we are using im.js the errors you can get are different. We would like to notify the user of any errors that appeared during loading of the default filters, such as the Pathways filter.

As an example, switch to XenMine and you will in the console an error saying that the XML query is not well formatted, as Gene.pathways.name doesn't exist in that mine.

The idea is to notify the user that "The Pathways filter wasn't able to be loaded due to missing concepts in the database model".

[PrastutiUpadhaya]

Is this issue assigned informally to anyone? I would like to try working on this @AdrianBZG