Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PostInstall): add supported wallets, add context to steps #935

Merged
merged 13 commits into from
Feb 26, 2025

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Feb 24, 2025

Context

Closes #874

Changes proposed in this pull request

  • List wallets in first step
    • Add logos for wallets
    • A wallet is unlisted if it's url is empty string. So, in future, we just need to set url to enable GateHub/Chimoney when they're supported.
  • Show wallet address screenshot depending on which wallet link was clicked in step 1 (default to Interledger Wallet)
  • Also, use different placeholder depending on selected wallet.

@github-actions github-actions bot added area: i18n area: pages/app area: pages Changes to any of extension's pages labels Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Extension builds preview

Name Link
Latest commit 7dbde12
Latest job logs Run #13546001020
BadgeDownload
BadgeDownload

@github-actions github-actions bot added the area: popup Improvements or additions to extension popup label Feb 25, 2025
@sidvishnoi sidvishnoi marked this pull request as ready for review February 26, 2025 08:24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot is taken from WICG/webmonetization#498.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot is taken from WICG/webmonetization#498.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot is taken from sandbox website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logo is extracted from website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logo is extracted from website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a manually created from two different SVGs from website.

@DarianM DarianM self-requested a review February 26, 2025 10:35
Copy link
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat postinstall ux 💯

@DarianM DarianM merged commit 6f094b2 into main Feb 26, 2025
9 checks passed
@DarianM DarianM deleted the post-install-improvements branch February 26, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: i18n area: pages/app area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp post-install steps to make it easier for users
3 participants