Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble running Letter Shop tutorial #33

Open
michielbdejong opened this issue Jan 3, 2018 · 1 comment
Open

Trouble running Letter Shop tutorial #33

michielbdejong opened this issue Jan 3, 2018 · 1 comment

Comments

@michielbdejong
Copy link
Contributor

Got this report from a user, via Gitter:

following the letter shop tutorial, and i did an npm install
ran into an error
so i checked the package.json file
found this
""ilp-plugin-xrp-escrow": "github:michielbdejong/ilp-plugin-xrp-escrow#72e4178","
commented it out, and npm install went fine
I am guessing this is the ilp-plugin-xrp-escrow plugin
"https://github.com/ripple/ilp-plugin-xrp-escrow"

@sasaki-san
Copy link

sasaki-san commented Apr 29, 2018

Hi @michielbdejong ,

The problem is caused by the package which ripple-lib depends on - jsonscheme which is no longer compatible with the previous versions of ripple-lib (<0.20.0). I fixed the problem by updating the version of ripple-lib to 0.21.0 in ilp-plugin-xrp-escrow repo.

However, I see that the xrp-escrow plugin is not maintained anymore, so I was wondering if I could push this fix to your cloned repo (michielbdejong/ilp-plugin-xrp-escrow) and merge, and then we could update this tutorials' packge.json by targeting to the latest ilp-plugin-xrp-escrow from your repo so that people who try to follow the tutorials can run it.

Here's my fix:
https://github.com/cinnapple/ilp-plugin-xrp-escrow/commit/ca26825af11b9d123768e5145781ce531545dd30

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants