Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pooltoy to follow best practices around handlers and msgServer #40

Open
okwme opened this issue Jul 21, 2021 · 0 comments
Open

Comments

@okwme
Copy link
Contributor

okwme commented Jul 21, 2021

The SDK is replacing the handler with a message server pattern. Pooltoy already uses this pattern but for some reason the handler is still present. The logic of the handler is such that it will always throw an error, so it's really not doing anything at all. We should be able to get rid of it but it would be good to make sure that we follow the same form as other popular modules (like bank or gov).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant